Exclude incompatible test targets.#2535
Merged
fweikert merged 1 commit intobazelbuild:masterfrom Apr 8, 2026
Merged
Conversation
lilygorsheneva
requested review from
Wyverald,
fweikert and
meteorcloudy
as code owners
copybara-service bot
pushed a commit
to bazelbuild/rules_cc
that referenced
this pull request
Apr 7, 2026
The target compatibility check doesn't actually work as expected; buildkite seems to perform bazel queries that resolve it anyway (see "Resolving test targets via bazel query") https://buildkite.com/bazel/google-rules-cc-presubmit/builds/1750/steps/canvas?sid=019d63a0-e600-42d1-94e4-d9f0785a7c90 If we want "@platforms//:incompatible" to work for disabling things we should update bazelbuild/continuous-integration/buildkite/bazelci.py to exclude it; draft PR bazelbuild/continuous-integration#2535 Google: unknown commit presubmits are flaky due to this? Either it gets cached or it gets analysis errors due to the compatibility thing. PiperOrigin-RevId: 896004253 Change-Id: I3f25af4ae8532424aa76498c6e617634075d1ce7
Contributor
Author
|
For context: Had to disable the test in 872b2fa |
fweikert
approved these changes
Apr 8, 2026
The "Resolving test targets via bazel query" phase doesn't filter them and passes an explicit list to "test" which can't filter it due to it being explicitly requested
fweikert
force-pushed
the
excludeincompatible
branch
from
0719688 to
6fc56b0
Compare
SalmaSamy
pushed a commit
that referenced
this pull request
Apr 9, 2026
The "Resolving test targets via bazel query" phase doesn't filter them and passes an explicit list to "test" which can't filter it due to it being explicitly requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Resolving test targets via bazel query" phase doesn't filter them and passes an explicit list to "test" which can't filter it due to it being explicitly requested