Skip to content

Conversation

@gregestren
Copy link
Collaborator

@gregestren gregestren commented Jul 30, 2025

No longer required since bazelbuild/bazel@bb7fb2d (Bazel 7.0.0).

- Remove _allowlist_function_transition attribute: no longer required since
  bazelbuild/bazel@bb7fb2d
  (Bazel 7.0+)
 - WORKSPACE -> MODULE.bazel
@gregestren gregestren requested a review from Wyverald as a code owner July 30, 2025 18:50
@gregestren gregestren changed the title configurations/** cleanups Remove outdated _allowlist_function_transition attribute Jul 30, 2025
@gregestren
Copy link
Collaborator Author

@Wyverald at first I deleted WORKSPACE, thinking I was adding a new MODULE.bazel. I didn't notice configurations/* already had both WORKSPACE and MODULE.bazel. Is it still preferred to keep both here?

@Wyverald
Copy link
Member

The WORKSPACE file is no longer needed (especially since it's empty), so I think we should delete it.

gregestren and others added 2 commits August 1, 2025 15:50
Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
@gregestren
Copy link
Collaborator Author

WORKSPACE already deleted.

Like my last PR I'll merge with CI failures since CI failures are at head.

@gregestren gregestren merged commit ebcf06c into bazelbuild:main Aug 1, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants