Add aix os constraint.#126
Merged
gregestren merged 1 commit intobazelbuild:mainfrom Sep 25, 2025
Merged
Conversation
Believe it or not, I may have to build for AIX with Bazel in the foreseable future. Having this here makes it possible to upstream that case into select() clauses of legacy C code that has made its way into the BCR.
Contributor
Author
|
cc/ @gregestren |
aiuto
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Sep 24, 2025
- switch from BCR to a private BUILD file. - verify that the bzip2 1.0.8 version we see in the original repo and the two mirrors is actually the same content. - then use the most available. - build shared library - continue to build static bzip2 tool as //deps/bzip2:bzip2 - integrate options currently used by Omnibus - preserve compile options for AIX, in case omnibus script goes away before we get there. - add basic smoke tests culled from upstream repository. - figure out how to install the - have omnibus use this Related: - bazelbuild/platforms#126
dd-mergequeue Bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Sep 25, 2025
Build bzip2 as a shared library. - switch from BCR to a private BUILD file. - verify that the bzip2 1.0.8 version we see in the original repo and the two mirrors is actually the same content. - then use the most available. - build shared library - continue to build static bzip2 tool as //deps/bzip2:bzip2 - integrate options currently used by Omnibus - preserve compile options for AIX, in case omnibus script goes away before we get there. - add basic smoke tests culled from upstream repository. For next time: - figure out if we actually need the symlinked .so files, and how to install them. - have omnibus use this Related: - bazelbuild/platforms#126
gregestren
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Believe it or not, I may have to build for AIX with Bazel in the foreseable future. Having this here makes it possible to upstream that case into select() clauses of legacy C code that has made its way into the BCR.