Closed
Conversation
DX has been deprecated for a long time, and is essentially unused in rules_android*. Unfortunately, dx_binary and the only binary that depends on it, main_dex_list_creator, are still used as attributes in the android_sdk() rule, and thus can't be easily deleted. This change nerfs the two aforementioned binaries into simple shell binaries that immediately fail. Fixes bazelbuild#298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DX has been deprecated for a long time, and is essentially unused in rules_android*. Unfortunately, dx_binary and the only binary that depends on it, main_dex_list_creator, are still used as attributes in the android_sdk() rule, and thus can't be easily deleted. This change nerfs the two aforementioned binaries into simple shell binaries that immediately fail.
Fixes #298