Move static library validation helper to ar_files
#257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't need to be staged for every compile or link action. The action that uses it stages `all_files`.
Collaborator
Author
|
A local run of |
comius
approved these changes
Oct 24, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
PiperOrigin-RevId: 691372917 Change-Id: Idebbc95f1e24990ec61d5224fbc28cd238a8fdbd
Collaborator
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
*** Reason for rollback *** Breaks cc_builtin_tests *** Original change description *** Copybara Merge: #257 BEGIN_PUBLIC Copybara import of the project: -- 12a8bd5 by Fabian Meumertzheim <fabian@meumertzhe.im>: Move static library validation helper to `ar_files` It doesn't need to be staged for every compile or link action. The action that uses it stages `all_files`. END_PUBLIC *** PiperOrigin-RevId: 695300596 Change-Id: If10c95c1867716c82a09ad3acdfd479beedcc6c5
Collaborator
Author
|
I'll take a look at some point, but it's not a high priority improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't need to be staged for every compile or link action. The action that uses it stages
all_files.