Add macOS support to examples/rule_based_toolchain #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
force-pushed
the
ks/add-macos-support-to-examples-rule_based_toolchain
branch
7 times, most recently
from
deac07f to
e63031b
Compare
keith
requested review from
armandomontanez,
c-mita,
comius,
pzembrod and
trybka
as code owners
fmeum
reviewed
Feb 27, 2025
This makes it easier to do basic testing of rules based toolchain changes on macOS. There are a few changes here: - Add `tags = ["manual"]` to avoid unnecessary downloads - Add `--target` to support cross compilation - Download clang for macOS - Cross compile to linux to avoid the need for a macOS sysroot download
keith
force-pushed
the
ks/add-macos-support-to-examples-rule_based_toolchain
branch
from
e63031b to
0b935e7
Compare
armandomontanez
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to do basic testing of rules based toolchain changes on macOS. There are a few changes here:
tags = ["manual"]to avoid unnecessary downloads--targetto support cross compilation