Apply default compile flags passed as attrs in Windows MSVC toolchain config#601
Closed
pikinier20 wants to merge 1 commit intobazelbuild:mainfrom
Closed
Apply default compile flags passed as attrs in Windows MSVC toolchain config#601pikinier20 wants to merge 1 commit intobazelbuild:mainfrom
pikinier20 wants to merge 1 commit intobazelbuild:mainfrom
Conversation
pikinier20
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
pikinier20
force-pushed
the
filip.zybala/msvc-compile-flags-fix
branch
from
e508bce to
6131d10
Compare
fmeum
approved these changes
Feb 12, 2026
trybka
approved these changes
Feb 12, 2026
Collaborator
trybka
left a comment
trybka
left a comment
There was a problem hiding this comment.
Looks like this was just an oversight. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows customization of Windows toolchain.
In our project, we are building a custom toolchain based on LLVM. For simplicity, we reuse the creation of toolchain config for Windows. However, we noticed that the compile flags passed by attributes are not passed to the compiler.
Since the same logic is present in creating GNU config, I assumed that somebody previously just missed it.