Open
Conversation
keith
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
armandomontanez
added
type: feature request
armandomontanez
approved these changes
Mar 24, 2026
keith
force-pushed
the
ks/add-local_defines-to-objc_library
branch
from
f1c31fc to
e3a6a7f
Compare
armandomontanez
added
the
untriaged
trybka
previously approved these changes
Apr 8, 2026
Collaborator
|
toolchain_api_diff_test is failing for this one as well. |
This mirrors cc_library Fixes bazelbuild/bazel#17482
keith
force-pushed
the
ks/add-local_defines-to-objc_library
branch
from
e3a6a7f to
562f284
Compare
Member
Author
|
looks like a bad rebase, fixed by dropping the rouge commit |
lilygorsheneva
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors cc_library
Fixes bazelbuild/bazel#17482