Skip to content

Expose interface_library_builder in toolchain#676

Open
keith wants to merge 2 commits intobazelbuild:mainfrom
keith:ks/expose-interface_library_builder-in-toolchain
Open

Expose interface_library_builder in toolchain#676
keith wants to merge 2 commits intobazelbuild:mainfrom
keith:ks/expose-interface_library_builder-in-toolchain

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Apr 2, 2026

Without this you have to hack in the path to your actual tool in your
toolchain. Currently the script in this repo is unusable and also only
does cp

Without this you have to hack in the path to your actual tool in your
toolchain. Currently the script in this repo is unusable and also only
does `cp`
@keith keith requested review from c-mita, pzembrod and trybka as code owners April 2, 2026 23:47
Copy link
Copy Markdown
Collaborator

@armandomontanez armandomontanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this is passed around through action configs. Exposing the tool this way seems like the wrong direction. I know this is a little frustrating.

My only initial idea is to pipe this through tool_paths from CcToolchainConfigInfo.

@armandomontanez armandomontanez added type: feature request Request for new, generally useful functionality that is missing P3 We're not considering working on this, but happy to review a PR. (No assignee) category: toolchains labels Apr 13, 2026
@keith
Copy link
Copy Markdown
Member Author

keith commented Apr 14, 2026

I don't mind doing that! I think this case is particularly weird. In all of my other prs that touch stuff like this I've been trying to move away from using tool_paths (which as you know aren't even supported by the rules based toolchains #667), so moving something into that seems pretty off. But at the same time unlike the other "fake" actions we've added, like llvm_cov, llvm-profdata or gcov those could at least maybe be real looking actions in the future. Where in this case this tool is passed as a path to another tool that actually does the linking https://github.com/keith/rules_cc/blob/796ec7430f070ff965055265141bb01703c8d8f5/cc/private/toolchain/unix_cc_toolchain_config.bzl#L1167

seems to me like making that a full action so we could call get_tool_for_action would be a bit weird. but maybe that's still better than the alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: toolchains P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request Request for new, generally useful functionality that is missing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants