Pass toolchain_type to LTO backend action creation for correct exec platform#709
Open
anguslees wants to merge 1 commit intobazelbuild:mainfrom
Open
Pass toolchain_type to LTO backend action creation for correct exec platform#709anguslees wants to merge 1 commit intobazelbuild:mainfrom
anguslees wants to merge 1 commit intobazelbuild:mainfrom
Conversation
…latform Pass the CC toolchain type to cc_internal.create_lto_backend_action and cc_internal.create_lto_backend_action_template so that these actions resolve their execution platform through the CC toolchain's auto exec group, matching the behavior of CppCompile and CppLink actions. Without this, LTO backend compile actions use the DEFAULT exec group (which ignores toolchain exec_compatible_with constraints when auto_exec_groups is enabled), causing them to be scheduled on the wrong execution platform in mixed-architecture RBE setups. Requires the corresponding Bazel change that adds the toolchain_type parameter to these cc_internal APIs.
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the CC toolchain type to cc_internal.create_lto_backend_action and cc_internal.create_lto_backend_action_template so that these actions resolve their execution platform through the CC toolchain's auto exec group, matching the behavior of CppCompile and CppLink actions.
Without this, LTO backend compile actions use the DEFAULT exec group (which ignores toolchain exec_compatible_with constraints when auto_exec_groups is enabled), causing them to be scheduled on the wrong execution platform in mixed-architecture RBE setups.
Requires the corresponding Bazel change that adds the toolchain_type parameter to these cc_internal APIs.