Make testing/e2e.sh a bazel test...

[damienmg]

So we can run it on Bazel.

We have docker test in Bazel, and we can depends on the bazel installer to get bazel inside the test so it should be possible.

[mattmoor]

AIUI this is blocked on the Bazel issue about making writing e2e testing easier? I did this specifically because doing this in Bazel was a PITA, but maybe things have evolved some.

[damienmg]

Actually @dslomov suggested to just use a http_archive on the bazel installer to ship Bazel inside the repo. That has the advantage that the test can use the bazel for execution platform so it make the test ready for remote execution.

We also have another part about making the testing framework easier but that's does not prevent e2e.sh to run in Bazel by itself.

If I get some time in the summer I'll tackle this one.

[ittaiz]

Just FYI- I tried this and it takes ~20 seconds just to do the installation of Bazel

[damienmg]

https://bazel-review.googlesource.com/c/15432 is doing that. You only pay once the install of Bazel (but not the unzipping, we might want to do that ahead of time).

If you use --experimental_repository_cache, you will not repay the download accross build.

[ittaiz]

@damienmg What in that CL does that? AFAICT the repository rule just downloads and extracts. If I remember correctly from my experiment the first time you run bazel after that you pay 20 seconds.
Am I incorrect?

[damienmg]

20seconds seems a lot but that is true, you unpack bazel. What I said is we can make that extraction part of the remote repository to not pay it using --install_path.

…

On Tue, Aug 22, 2017 at 5:06 PM Ittai Zeidman ***@***.***> wrote: @damienmg <https://github.com/damienmg> What in that CL does that? AFAICT the repository rule just downloads and extracts. If I remember correctly from my experiment the first time you run bazel after that you pay 20 seconds. Am I incorrect? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#73 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADjHf9nWKkgwzgLydrVnLC23BZkBz-tQks5sau5sgaJpZM4OI0rw> .

[ittaiz]

--install_path? Couldn't find it in the codebase or command line reference.
How can we pay the extraction in the repository rule? by just executing "bazel version" for example in the rule?

[damienmg]

--install_base sorry. Yes we can simply unzip bazel itself.

…

On Tue, Aug 22, 2017 at 5:30 PM Ittai Zeidman ***@***.***> wrote: --install_path? Couldn't find it in the codebase or command line reference. How can we pay the extraction in the repository rule? by just executing "bazel version" for example in the rule? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#73 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADjHf0WV8h7ALS9zkny4m-0ceDWNLTVnks5savP-gaJpZM4OI0rw> .

[ittaiz]

nice. Should I open an issue (in bazel obviously) about extracting it to another repo and about doing the unzip?

[damienmg]

I think we can piggy back to the existing issue about testing skylark code?

…

On Wed, Aug 23, 2017 at 10:24 AM Ittai Zeidman ***@***.***> wrote: nice. Should I open an issue (in bazel obviously) about extracting it to another repo and about doing the unzip? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#73 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADjHf0UbGWqFAfI95Jga-IGPqBMklVBhks5sa-G5gaJpZM4OI0rw> .

[ittaiz]

as usual you're right :) On Wed, Aug 23, 2017 at 12:29 PM Damien Martin-Guillerez < notifications@github.com> wrote:

…

I think we can piggy back to the existing issue about testing skylark code? On Wed, Aug 23, 2017 at 10:24 AM Ittai Zeidman ***@***.***> wrote: > nice. Should I open an issue (in bazel obviously) about extracting it to > another repo and about doing the unzip? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #73 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/ADjHf0UbGWqFAfI95Jga-IGPqBMklVBhks5sa-G5gaJpZM4OI0rw > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#73 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIFw_3XMh8gMmbDBOw3s96MmxLFGvTks5sa_DrgaJpZM4OI0rw> .

[ittaiz]

@mattmoor I think this is no longer blocked.
@damienmg released https://github.com/bazelbuild/bazel-integration-testing a while ago and we're iterating over it to add more features.
It has basic support for java, support for python (not sure at which state) and there's an active PR for go support.

[damienmg]

I know :) I need to take a stab at it...