Skip to content

Update buildifier warnings #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcj merged 5 commits into from
May 23, 2021
Merged

Update buildifier warnings #1866

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50af805
Update buildifier warnings
pcj May 23, 2021
b4b88b7
Try allow previously excluded
pcj May 23, 2021
bcecd69
Final warning exclusion list
pcj May 23, 2021
ab2c234
Missed -return-value
pcj May 23, 2021
6507c8e
Rebase master
pcj May 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
---
buildifier:
version: 4.0.1
# Check for issues with the format of our bazel config files.
# All warnings from https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md
# are enabled except:
# rule-impl-return, uninitialized, return-value, rule-impl-return
# TODO (suvanjan): Re-enable once issues are fixed.
warnings: "attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,confusing-name,constant-glob,ctx-actions,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,function-docstring,git-repository,http-archive,integer-division,load,load-on-top,module-docstring,name-conventions,native-build,native-package,no-effect,out-of-order-load,output-group,package-name,package-on-top,redefined-variable,repository-name,same-origin-load,string-iteration,unreachable,unsorted-dict-items,unused-variable"
bazel: 4.0.0 # keep in sync with .bazelversion
warnings: "-rule-impl-return,-return-value,-function-docstring-args,-print,-skylark-comment,-provider-params,-unnamed-macro"
bazel: 4.0.0
tasks:
default_workspace_ubuntu1804:
platform: ubuntu1804
Expand Down