README.md: rename client.json -> config.json in one place.
#2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was unlucky to miss all the other references to `config.json` when I was setting up, so I named my file `client.json`, looking instead only at the label changed by this commit. When I later ran a `container_push` target it failed with "permission denied" issues. I read the shell script generated by `container_push` and saw that it passes an argument to give the path to the _directory_ of the config file, rather than the path to the file itself. That made me realize that I had probably given the file the wrong name; the Docker client didn't find a `config.json` file in that directory and ignored all other files.
saser
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
uhthomas
approved these changes
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I was unlucky to miss all the other references to
config.jsonwhen I wassetting up, so I named my file
client.json, looking instead only at the labelchanged by this commit.
When I later ran a
container_pushtarget it failed with "permission denied"issues. I read the shell script generated by
container_pushand saw that itpasses an argument to give the path to the directory of the config file,
rather than the path to the file itself.
That made me realize that I had probably given the file the wrong name; the
Docker client didn't find a
config.jsonfile in that directory and ignored allother files.