Skip to content

Conversation

@gudmundur-heimisson
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

If the docker executable path contains a space (for example when running under WSL), then all of the generated shell templates that use the docker executable fail with a file not found error.

Issue Number: N/A

What is the new behavior?

Execution will now succeed for docker executables where the path contains a space.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Tested this locally on my WSL2 machine and docker rules now work.

@google-cla
Copy link

google-cla bot commented Aug 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gudmundur-heimisson
Copy link
Author

gudmundur-heimisson commented Aug 22, 2022

I have just signed the CLA thing, not sure how to rerun the check.

EDIT: Figured it out, diregard this comment.

@gudmundur-heimisson
Copy link
Author

Friendly ping.

@uhthomas uhthomas merged commit c823a69 into bazelbuild:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants