-
Notifications
You must be signed in to change notification settings - Fork 244
Add configuration for stale bot #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Ideally we would have the resources to address and resolve all issues, and review and merge all pull requests. But we don't. Rather than leave these open indefinitely, it's better to set user expectations that these will just age out.
|
Note: I think someone with permissions needs to create the "Can Close?" label on this repo before the GH action runs |
cgruber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it in general, one quick question before merging.
| # Can revisit if these get stale | ||
| exempt-all-assignees: true | ||
| # Issues with these labels will never be considered stale | ||
| exempt-issue-labels: "need: discussion,cleanup" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these exact, or are they a match? We have labels more like this: type: cleanup I don't think these exempt labels would ever trigger on this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume they are exact, we could check the specification. I'm on vacation at the moment, feel free to amend or add commits.
Assuming we take this PR (and I'm inclined to, once we figure out the other issues with specific labels) I"ll add it. |
|
Gotcha. I'll take care of it.
…On Fri, Jul 9, 2021, 20:01 Alex Eagle ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/stale.yml
<#551 (comment)>
:
> + with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+ # NB: We start with very long duration while trimming existing issues,
+ # with the hope to reduce when/if we get better at keeping up with user support.
+
+ # The number of days old an issue can be before marking it stale.
+ days-before-stale: 180
+ # Number of days of inactivity before a stale issue is closed
+ days-before-close: 30
+
+ # If an issue/PR is assigned, trust the assignee to stay involved
+ # Can revisit if these get stale
+ exempt-all-assignees: true
+ # Issues with these labels will never be considered stale
+ exempt-issue-labels: "need: discussion,cleanup"
I assume they are exact, we could check the specification. I'm on vacation
at the moment, feel free to amend or add commits.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#551 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQ3YS25XOSNKR4XVVITHDTW6ZZFANCNFSM46JCLUJQ>
.
|
Should help with issue/PR triage.
Ideally we would have the resources to address and resolve all issues, and review and merge all pull requests. But we don't.
Rather than leave these open indefinitely, it's better to set user expectations that these will just age out.
This is the same config used in rules_nodejs, rules_docker, and rules_python.