Skip to content

Enabled rust_doc_test for crate_universe #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Enabled rust_doc_test for crate_universe #1232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions crate_universe/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("@crate_universe_crate_index//:defs.bzl", "aliases", "all_crate_deps")
load("@rules_rust//rust:defs.bzl", "rust_binary", "rust_doc", "rust_library", "rust_test")
load("@rules_rust//rust:defs.bzl", "rust_binary", "rust_doc", "rust_doc_test", "rust_library", "rust_test")
load("//crate_universe:version.bzl", "VERSION")

exports_files(
Expand Down Expand Up @@ -114,10 +114,13 @@ rust_doc(
visibility = ["//visibility:public"],
)

# `rust_doc_test` does not currently work. See:
# https://github.com/bazelbuild/rules_rust/issues/980
#
# rust_doc_test(
# name = "rustdoc_test",
# crate = ":cargo_bazel",
# )
rust_doc_test(
name = "rustdoc_test",
crate = ":cargo_bazel",
# TODO: This target fails on windows with the error tracked in:
# https://github.com/bazelbuild/rules_rust/issues/1233
target_compatible_with = select({
"@platforms//os:windows": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
)