Fixed build issues in release artifact #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Apr 26, 2022
UebelAndre
changed the title
UebelAndre
commented
Apr 26, 2022
| ) | ||
|
|
||
| sh_binary( | ||
| cc_binary( |
Collaborator
Author
There was a problem hiding this comment.
This being a sh_binary added an unnecessary reliance on bash for windows as well as required executable files be present in release artifacts, which there are none of.
UebelAndre
commented
Apr 26, 2022
| sh_binary( | ||
| name = "fetch_shas", | ||
| srcs = ["fetch_shas.sh"], | ||
| tags = ["manual"], |
Collaborator
Author
There was a problem hiding this comment.
This avoids requiring an executable file in the release artifact.
illicitonion
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1272 (comment)