Remove triple field from triple struct in favor of str
#1297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I have:
then
triple.tripledoes not do a good job conveying what is going on; how the two things calledtriple(actually 3 if you count the function namedtripleas well) are different from one another.To improve this in #1289 I added a
strfield to the triple struct, just duplicating the contents of thetriplefield but with a clearer name. In contrast totriple.triple, writingf(triple.str)is clearer to me and conveys "oh yeahftakes a string argument (as opposed to a struct) andtriple.stris the string representation of the triple".This PR removes the field
triple.triplein favor oftriple.strsince there is no longer a reason to use the former.