Skip to content

Conversation

@UebelAndre
Copy link
Collaborator

This silences the following warnings (which are out of our control):

INFO: From Compiling Rust rlib libc (59 files):
warning: unnecessary trailing semicolon
  --> external/libc/src/macros.rs:58:21
   |
58 |             $($body);*
   |                     ^ help: remove this semicolon
   |
   = note: `#[warn(redundant_semicolons)]` on by default

warning: unnecessary parentheses around assigned value
   --> external/libc/src/unix/bsd/apple/mod.rs:345:38
    |
345 | pub const LC_COLLATE_MASK: ::c_int = (1 << 0);
    |                                      ^      ^
    |
    = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
    |
345 - pub const LC_COLLATE_MASK: ::c_int = (1 << 0);
345 + pub const LC_COLLATE_MASK: ::c_int = 1 << 0;
    |

warning: unnecessary parentheses around assigned value
   --> external/libc/src/unix/bsd/apple/mod.rs:346:36
    |
346 | pub const LC_CTYPE_MASK: ::c_int = (1 << 1);
    |                                    ^      ^
    |
help: remove these parentheses
    |
346 - pub const LC_CTYPE_MASK: ::c_int = (1 << 1);
346 + pub const LC_CTYPE_MASK: ::c_int = 1 << 1;
    |

warning: unnecessary parentheses around assigned value
   --> external/libc/src/unix/bsd/apple/mod.rs:347:39
    |
347 | pub const LC_MESSAGES_MASK: ::c_int = (1 << 2);
    |                                       ^      ^
    |
help: remove these parentheses
    |
347 - pub const LC_MESSAGES_MASK: ::c_int = (1 << 2);
347 + pub const LC_MESSAGES_MASK: ::c_int = 1 << 2;
    |

warning: unnecessary parentheses around assigned value
   --> external/libc/src/unix/bsd/apple/mod.rs:348:39
    |
348 | pub const LC_MONETARY_MASK: ::c_int = (1 << 3);
    |                                       ^      ^
    |
help: remove these parentheses
    |
348 - pub const LC_MONETARY_MASK: ::c_int = (1 << 3);
348 + pub const LC_MONETARY_MASK: ::c_int = 1 << 3;
    |

warning: unnecessary parentheses around assigned value
   --> external/libc/src/unix/bsd/apple/mod.rs:349:38
    |
349 | pub const LC_NUMERIC_MASK: ::c_int = (1 << 4);
    |                                      ^      ^
    |
help: remove these parentheses
    |
349 - pub const LC_NUMERIC_MASK: ::c_int = (1 << 4);
349 + pub const LC_NUMERIC_MASK: ::c_int = 1 << 4;
    |

warning: unnecessary parentheses around assigned value
   --> external/libc/src/unix/bsd/apple/mod.rs:350:35
    |
350 | pub const LC_TIME_MASK: ::c_int = (1 << 5);
    |                                   ^      ^
    |
help: remove these parentheses
    |
350 - pub const LC_TIME_MASK: ::c_int = (1 << 5);
350 + pub const LC_TIME_MASK: ::c_int = 1 << 5;
    |

warning: 7 warnings emitted

@UebelAndre UebelAndre changed the title Silence warnings for example/test dependencies Address warnings for example/test dependencies May 3, 2022
@UebelAndre UebelAndre requested review from hlopko and illicitonion and removed request for illicitonion May 3, 2022 01:40
@UebelAndre UebelAndre merged commit bddc4bd into bazelbuild:main May 3, 2022
@UebelAndre UebelAndre deleted the warnings branch May 3, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants