Add crate_name attribute #2118
Merged
Add crate_name attribute #2118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidefield
force-pushed
the
add-crate-name-attr
branch
from
fae679e to
de45cf1
Compare
scentini
approved these changes
Aug 18, 2023
Collaborator
|
LGTM, waiting for @UebelAndre to review as per request. |
ttiurani
pushed a commit
to ttiurani/rules_rust
that referenced
this pull request
Sep 15, 2023
This PR adds `crate_name` attribute to `rust_proto_library` and `rust_grpc_library` rules. This aligns with `crate_name` attribute provided in other rules to allow custom crate name different from label name. Setting `--crate-name` flag to `rustc_flags` attribute is not an option because `rustc` does not allow `--crate-name` flag to be set twice. @UebelAndre Would you mind reviewing this PR when you have a chance? ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
crate_nameattribute torust_proto_libraryandrust_grpc_libraryrules. This aligns withcrate_nameattribute provided in other rules to allow custom crate name different from label name.Setting
--crate-nameflag torustc_flagsattribute is not an option becauserustcdoes not allow--crate-nameflag to be set twice.@UebelAndre Would you mind reviewing this PR when you have a chance?