Cleanup args construction #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
force-pushed
the
zbarsky/cleanup
branch
from
7bb8279 to
99df3c5
Compare
dzbarsky
force-pushed
the
zbarsky/cleanup
branch
from
99df3c5 to
017d970
Compare
ttiurani
pushed a commit
to ttiurani/rules_rust
that referenced
this pull request
Sep 15, 2023
Some minor optimizations to analysis time memory usage (avoid creating
some list temporaries, some extra strings, etc.)
Some of the usage might be simpler as `args.add("foo", foo)` instead of
`args.add(foo, format="foo=%s")` but I opted to keep the usage the same
as before for safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor optimizations to analysis time memory usage (avoid creating some list temporaries, some extra strings, etc.)
Some of the usage might be simpler as
args.add("foo", foo)instead ofargs.add(foo, format="foo=%s")but I opted to keep the usage the same as before for safety.