Fix linkstamp deps in proc macros #3749
Merged
+45
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were not being linked in for two reasons: - missing `_use_grep_includes` attribute on the `rust_proc_macro` rule: this attribute & condition are entirely dead code now ==> delete them. - the explicit crate type list doesn't include `proc-macro` ==> add it.
sam-mccall
force-pushed
the
linkstamp
branch
from
ec0bd5a to
2bdbc8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were not being linked in for two reasons:
_use_grep_includesattribute on therust_proc_macrorule:this attribute & condition are entirely dead code now ==> delete them.
proc-macro==> add it.