Add support for ${pwd} for -L, -resource-dir and INCLUDE env var#3832
Add support for ${pwd} for -L, -resource-dir and INCLUDE env var#3832illicitonion merged 2 commits intobazelbuild:mainfrom
${pwd} for -L, -resource-dir and INCLUDE env var#3832Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
c6299e7 to
96bc9e9
Compare
${pwd} for -L, -B, -resource-dir and INCLUDE env var${pwd} for -L, -resource-dir and INCLUDE env var
|
This looks good, thanks! Please could you expand the tests in |
96bc9e9 to
9954be6
Compare
|
@illicitonion Added tests for both commits, and fixed a couple of bugs. I also merged both logic (equal vs. rest) now given I needed to reason about equal signed variant. |
9954be6 to
b0511ae
Compare
|
Anything blocking that to be merged? |
|
I just hit this with |
illicitonion
left a comment
There was a problem hiding this comment.
Sorry for the delay here, it's been a busy few weeks! This LGTM, thanks so much for the tests (and fixes), this looks great!
No description provided.