Fix reproducible warning in crates_repository#3904
Merged
UebelAndre merged 2 commits intobazelbuild:mainfrom Mar 22, 2026
Merged
Fix reproducible warning in crates_repository#3904UebelAndre merged 2 commits intobazelbuild:mainfrom
crates_repository#3904UebelAndre merged 2 commits intobazelbuild:mainfrom
Conversation
illicitonion
approved these changes
Mar 22, 2026
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM but it looks like there are errors running the pipeline? Let's maybe add the pipeline as a separate PR where I can review passing and failing runs for their output?
| @@ -0,0 +1,47 @@ | |||
| """Alias that transitions its target to `compilation_mode=opt`. Use `transition_alias="opt"` to enable.""" | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| """Alias that transitions its target to `compilation_mode=opt`. Use `transition_alias="opt"` to enable.""" | |
| """Alias that transitions its target `compilation_mode`.""" |
| } | ||
|
|
||
| // Skip any file or directory inside a known volatile directory | ||
| if entry.path().ancestors().any(|ancestor| { |
Collaborator
There was a problem hiding this comment.
Optional, but: it would be slightly cheaper to use https://docs.rs/walkdir/latest/walkdir/struct.FilterEntry.html#method.skip_current_dir to stop iterating into those directories, rather than having to check all ancestors for every path
Collaborator
Author
|
I didn't realize #3346 was in this change! It's totally unrelated! So sorry I didn't catch this! |
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a noisy warning for users of
crates_repository: