Add patches making rust analyzer crates deterministic#3929
Merged
UebelAndre merged 7 commits intobazelbuild:mainfrom Mar 26, 2026
Merged
Add patches making rust analyzer crates deterministic#3929UebelAndre merged 7 commits intobazelbuild:mainfrom
UebelAndre merged 7 commits intobazelbuild:mainfrom
Conversation
UebelAndre
approved these changes
Mar 25, 2026
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! I think this is good. This is more of a tool that rules_rust provides and if there's non-determinism in it then we should totally get that patched.
Contributor
Author
|
Ideally we should contribute these patches upstream and get rid of them once the new versions are released. |
UebelAndre
requested changes
Mar 25, 2026
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Sorry, just one thought that should hopefully prevent a regression.
hofbi
force-pushed
the
rust-analyzer-crate-determinism-patches
branch
from
69f8700 to
981e099
Compare
Contributor
Author
|
@UebelAndre I think I got it working now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kind of related to #3547 but not directly a
-syscrate. Regardless, these crates are non deterministic and these patches make them deterministic.