Add support for experimental_output_paths#4011
Conversation
UebelAndre
force-pushed
the
path_mapping
branch
8 times, most recently
from
a2c755c to
68242ac
Compare
| rust_analyzer_tests_linux: | ||
| name: Rust-Analyzer Linux Tests | ||
| ide_integration_tests_linux: | ||
| name: IDE VSCode Tests |
There was a problem hiding this comment.
Are the Rust-Analyzer -> IDE VSCode config changes related to the rest of the PR?
There was a problem hiding this comment.
I needed to trim down the number of jobs since we're hitting the 128 limit
| rustc_flags.add('--cfg=feature="no_std"') | ||
|
|
||
| # Add target specific flags last, so they can override previous flags | ||
| authored_rustc_flags = getattr(attr, "rustc_flags", []) |
There was a problem hiding this comment.
What does "authored" mean in this context?
There was a problem hiding this comment.
Flags users added to their targets. I can use whatever name you'd prefer. I know I'm bad at naming 😅
|
I think this has broken a pattern somewhat common in embedded Rust where one crate puts a file into build script outputs, and another create references it from its build script in linker flags. I bisected the problem to 175bf94, but didn't yet understand whether the problem is in this commit or somewhere on my side. |
Interesting, I would be surprised this has an impact assuming you're not using |
|
No, I don't. |
Can you make a small repro in a pull-request somewhere in //cargo/tests/cargo_build_script ? |
3 participants
For details on path mapping see bazelbuild/bazel#22658
Changes:
out_dirto avoid location expanded environment variables.construct_argumentsis updated to supportrustc_flagsas anArgsobject.Listis still supported though