Make runfiles.bash available via PATH in all sh_*() rules #24
+32
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mering
commented
Apr 28, 2025
|
|
||
| run_environment_info = RunEnvironmentInfo( | ||
| environment = { | ||
| "RUNFILES_BIN": "../bin", |
Contributor
Author
There was a problem hiding this comment.
I thought about appending this to $PATH here directly to avoid another line in the copyable snippet but I couldn't think of a good way to get the toolchain default $PATH to append to.
fmeum
reviewed
Apr 28, 2025
| # { echo>&2 "ERROR: cannot find $f"; exit 1; }; f=; set -e | ||
| # # --- end runfiles.bash initialization v3 --- | ||
| # | ||
| # PATH=$PATH:$RUNFILES_BIN |
Collaborator
There was a problem hiding this comment.
How would this work if the script is executed within an action, say a genrule? RunEnvironmentInfo only applies to bazel run, so this variable wouldn't be set.
Contributor
Author
There was a problem hiding this comment.
Is there a way to set action env somehow in the rule as well?
Contributor
Author
There was a problem hiding this comment.
Could you add a test to cover this use case?
Would it be enough to provide a reasonable default for this case like ${RUNFILES_BIN:-bin/runfiles.bash}?
This significantly simplifies the snippet which needs to be copied into every main script.
mering
force-pushed
the
runfiles-implicit-path
branch
from
c585f02 to
4518418
Compare
fmeum
added a commit
that referenced
this pull request
Aug 20, 2025
This avoid the need to copy&paste the verbose initialization snippet into every script. This should resolve the issues raised in #24. --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Contributor
Author
|
Closing this in favor of #38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly simplifies the snippet which needs to be copied into every main script.