Fix shellcheck findings #30
Merged
+27
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add rules_shellcheck to avoid regressions.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several shellcheck warnings by refining shell script patterns and adds a shellcheck test rule to prevent regressions.
- Updated tests/build file to include a shellcheck test target
- Modified runfiles.bash to address shellcheck warnings and improve error handling
- Updated BUILD and MODULE files to support the new shellcheck rules
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/runfiles/BUILD | Added a shellcheck_test target |
| shell/runfiles/runfiles.bash | Updated shell patterns, quoting, and error handling improvements |
| shell/runfiles/BUILD | Added exports_files to expose runfiles.bash |
| MODULE.bazel | Added rules_shellcheck dependency |
meteorcloudy
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add rules_shellcheck to avoid regressions.
Fixes #28