Add support for --incompatible_compact_repo_mapping_manifest
#32
+112
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
fmeum
force-pushed
the
compact-repo-mapping
branch
from
f66b41b to
e55e7c9
Compare
fmeum
force-pushed
the
compact-repo-mapping
branch
from
fefc964 to
c9ffb88
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new --incompatible_compact_repo_mapping_manifest flag by introducing additional tests to verify both directory‐ and manifest-based repo mapping behaviors and by updating the runfiles lookup logic to consistently escape grep pattern arguments. Key changes include:
- New bash test functions to validate repository mapping resolution from both extension and main repos.
- The introduction of a helper function (__runfiles_escape_grep) to escape special regex characters.
- Modifications in runfiles.bash to use the new escaping function in several lookup functions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/runfiles/runfiles_test.bash | Added tests for directory- and manifest-based repository mapping |
| shell/runfiles/runfiles.bash | Introduced a helper for escaping grep patterns and updated rlocation logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the way, fix two more bugs:
Work towards bazelbuild/bazel#26262