Update runfiles library label in setup instructions #35
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still pointed to `bazel_tools`, which works, but we would eventually want to drop.
fmeum
changed the title
|
I was just about to create a similar PR. There's various other references to bazel_tools in runfiles.bash. Do we want to also fix those? For example, in the actual implementation itself: rules_shell/shell/runfiles/runfiles.bash Line 93 in 6501f73 |
meteorcloudy
approved these changes
Aug 11, 2025
Collaborator
Author
These are needed to preserve backwards compatibility with existing init snippets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still pointed to
bazel_tools, which works for now but should be dropped eventually.