fix: do not allow GREP_XXX env vars from breaking rlocation
#36
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Aug 1, 2025
shell/runfiles/runfiles.bash
Outdated
| function __runfiles_maybe_grep() { | ||
| # The GREP_XXX variables influence how grep behaves. Specifically, they can | ||
| # affect the output from the grep command. | ||
| unset GREP_COLOR |
Collaborator
There was a problem hiding this comment.
Is this local to the function? GREP_COLOR= as a prefix for the actual invocation would be more obviously free of side effects.
fmeum
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grep command can be influenced by
GREP_XXXenvironment variables. If set, they can affect the behavior/output of the command, causingrlocationto fail.