Update swift_import docs and add warning
#1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
requested review from
BalestraPatrick,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
luispadron
force-pushed
the
luis/update-swift_import-docs
branch
2 times, most recently
from
5f2fe0c to
8cf0f53
Compare
luispadron
force-pushed
the
luis/update-swift_import-docs
branch
2 times, most recently
from
fdaf2ea to
c2424ac
Compare
brentleyjones
approved these changes
Apr 1, 2024
jszumski
approved these changes
Apr 1, 2024
luispadron
force-pushed
the
luis/update-swift_import-docs
branch
from
e604ecf to
4657c74
Compare
Updates the `swift_import` documentation to provide more information on the `swiftinterface` attribute. This attribute is required when importing pre-built Swift targets across Xcode and/or OS versions. Additionally, adds a warning when `swiftinterface` is used alongside `swiftmodule` as this used to just drop `swiftinterface` silently. We'll make this a failure in a new major version to not break users. Co-authored-by: John Szumski <784312+jszumski@users.noreply.github.com>
luispadron
force-pushed
the
luis/update-swift_import-docs
branch
from
4657c74 to
81f151e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
swift_importdocumentation to provide more information on theswiftinterfaceattribute. This attribute is required when importing pre-built Swift targets across Xcode and/or OS versions.Additionally, adds a warning when
swiftinterfaceis used alongsideswiftmoduleas this used to just dropswiftinterfacesilently. We'll make this a failure in a new major version to not break users.