Adding target name to output path for plugin executable #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymurmustafaiev
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
…_plugins # Conflicts: # swift/swift_compiler_plugin.bzl
brentleyjones
approved these changes
Jul 17, 2024
Collaborator
|
Thanks! |
tcamin
pushed a commit
to Subito-it/rules_swift
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding target_name to output path of swift plugin executable. Feature covered by
SWIFT_FEATURE_ADD_TARGET_NAME_TO_OUTPUTflag.Without this change and
SWIFT_FEATURE_ADD_TARGET_NAME_TO_OUTPUTenabled, we have naming collisions as bazel makes executable file on root folder, and in this root folder we make ourtarget_namefolder with all other files like: swiftinterface, headers, etc.By adding this change, we put executable in same target_name folder with all other generated files