Switch the Swift rules over to toolchains #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
Sep 30, 2024
Collaborator
Author
|
I need to add toolchains as well (#1321). Not sure if this is a breaking change. I know for rules_apple to be able to use this they need to update a couple call sites. But since we are still sticking the toolchain in an attribute, I believe the old ways continue to work. Maybe it can get odd in mixed non-toolchain/toolchain scenarios? I guess wondering if we need to bump the compatibility version again for this change (I hope not). |
Collaborator
Author
|
Without changing anything in rules_apple, this change + #1321 + registering the toolchains still works for me locally. |
brentleyjones
force-pushed
the
bj/switch-the-swift-rules-over-to-toolchains
branch
6 times, most recently
from
ea8aae6 to
be27747
Compare
Collaborator
Author
|
Will merge #1323 first. |
Collaborator
Author
|
This change passes our CI, so it's probably safe without bumping our compatibility version. |
PiperOrigin-RevId: 503982850 (cherry picked from commit c42aad2) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/switch-the-swift-rules-over-to-toolchains
branch
from
865e979 to
3da12f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 503982850
(cherry picked from commit c42aad2)