Provide a way for aspects to participate in swift_feature_allowlist checking
#1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checking This lets aspects enable/disable features without having to add every package where that aspect might be applied to targets to the `packages` of the allowlist. PiperOrigin-RevId: 596900977 (cherry picked from commit 0206011) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 14, 2024
… checking. This lets aspects enable/disable features without having to add every package where that aspect might be applied to targets to the `packages` of the allowlist. PiperOrigin-RevId: 596900977
thii
approved these changes
Oct 14, 2024
brentleyjones
deleted the
bj/provide-a-way-for-aspects-to-participate-in-swift_feature_allowlist-checking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets aspects enable/disable features without having to add every package where that aspect might be applied to targets to the
packagesof the allowlist.PiperOrigin-RevId: 596900977
(cherry picked from commit 0206011)