Add the swift.enable_v6 feature to support migration to the Swift 6 language mode
#1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 15, 2024
… language mode. This flag is designed with ease of migration in mind. On toolchains that directly support the Swift 6 language mode (none have been released yet), enabling this feature on a target will simply pass `-swift-version 6` to the compiler. On older compilers however, it will instead pass the equivalent set of `-enable-upcoming-feature` flags as defined inside the compiler. This allows code to begin migrating to Swift 6 mode even before they switch to a Swift 6 toolchain. PiperOrigin-RevId: 629396220
brentleyjones
referenced
this pull request
Oct 15, 2024
…ompilers when using `swift.enable_v6`. Even in Swift 5.10, `StrictConcurrency` is only an experimental feature: https://github.com/apple/swift/blob/swift-5.10-RELEASE/include/swift/Basic/Features.def#L221 PiperOrigin-RevId: 631028867
brentleyjones
force-pushed
the
bj/swift.enable_v6
branch
from
afa4dbf to
633aa1d
Compare
… language mode This flag is designed with ease of migration in mind. On toolchains that directly support the Swift 6 language mode (none have been released yet), enabling this feature on a target will simply pass `-swift-version 6` to the compiler. On older compilers however, it will instead pass the equivalent set of `-enable-upcoming-feature` flags as defined inside the compiler. This allows code to begin migrating to Swift 6 mode even before they switch to a Swift 6 toolchain. PiperOrigin-RevId: 629396220 (cherry picked from commit 86f356c , f1765e6, 8065c86, and 3cb393f) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/swift.enable_v6
branch
from
633aa1d to
ccc5a71
Compare
luispadron
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is designed with ease of migration in mind. On toolchains that directly support the Swift 6 language mode (none have been released yet), enabling this feature on a target will simply pass
-swift-version 6to the compiler. On older compilers however, it will instead pass the equivalent set of-enable-upcoming-featureflags as defined inside the compiler. This allows code to begin migrating to Swift 6 mode even before they switch to a Swift 6 toolchain.PiperOrigin-RevId: 629396220
(cherry picked from commit 86f356c , f1765e6, 8065c86, and 3cb393f)