Fix windows toolchain target_compatible_with #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like this was incorrectly targeting apple constraints, when really if this works at all today it will only be able to build windows targets for now. Fixes #1614
keith
requested review from
aaronsky,
adincebic,
brentleyjones,
luispadron and
mattrobmattrob
as code owners
Member
Author
|
tried to get ci working on #1615 but need some help from Saleem |
aaronsky
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this was incorrectly targeting apple constraints, when
really if this works at all today it will only be able to build windows
targets for now.
Fixes #1614