Produce .swiftsourceinfo file as output of swift_library rule.
#692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
brentleyjones
referenced
this pull request
Sep 28, 2021
Declares `.swiftsourceinfo` as an output file of a compile action and threads the file through to be an output of the swift_library rule. PiperOrigin-RevId: 398579438
keith
approved these changes
Sep 29, 2021
brentleyjones
deleted the
bj/produce-.swiftsourceinfo-file-as-output-of-swift_library-rule
branch
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
…elbuild#692) Declares `.swiftsourceinfo` as an output file of a compile action and threads the file through to be an output of the swift_library rule. PiperOrigin-RevId: 398579438 (cherry picked from commit 4e45e79) # Conflicts: # swift/internal/compiling.bzl Fixes bazelbuild#496 Closes bazelbuild#523 Co-authored-by: Googler <noreply@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declares
.swiftsourceinfoas an output file of a compile action and threads the file through to be an output of the swift_library rule.PiperOrigin-RevId: 398579438
(cherry picked from commit 4e45e79)
Fixes #496
Closes #523