Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Update to nodejs rules 0.31.1#453

Closed
gregmagolan wants to merge 1 commit intobazelbuild:masterfrom
gregmagolan:nodejs-binary-entry-point-labels
Closed

Update to nodejs rules 0.31.1#453
gregmagolan wants to merge 1 commit intobazelbuild:masterfrom
gregmagolan:nodejs-binary-entry-point-labels

Conversation

@gregmagolan
Copy link
Copy Markdown
Contributor

@gregmagolan gregmagolan commented May 29, 2019

nodejs_binary entry_point is now a label. See release notes https://github.com/bazelbuild/rules_nodejs/releases/tag/0.31.0 for more info.

#455 should land first.

This commit is a pre-req to bazel-contrib/rules_nodejs#777

@gregmagolan gregmagolan changed the title Update nodejs_binary entry points to labels WIP: Update nodejs_binary entry points to labels May 29, 2019
@gregmagolan
Copy link
Copy Markdown
Contributor Author

gregmagolan commented Jun 2, 2019

Need rules_nodejs snapshot builds of npm packages to fix the error here that target is using jasmine_node_test out of @bazel/jasmine:

ERROR: /workdir/internal/BUILD.bazel:115:1: //internal:test: invalid label '@bazel/jasmine/src/jasmine_runner.js' in attribute 'entry_point' in 'nodejs_test' rule: invalid repository name '@bazel/jasmine/src/jasmine_runner.js': workspace names may contain only A-Z, a-z, 0-9, '-', '_' and '.'
--
  | ERROR: /workdir/internal/BUILD.bazel:115:1: //internal:test: missing value for mandatory attribute 'entry_point' in 'nodejs_test' rule
  | ERROR: package contains errors: internal
  | WARNING: Target pattern parsing failed.
  | INFO: Build option --legacy_external_runfiles has changed, discarding analysis cache.
  | ERROR: /workdir/internal/BUILD.bazel:137:1: Target '//internal:common/compilation.bzl' contains an error and its package is in error and referenced by '//internal:npm_package_assets'
  | ERROR: /workdir/internal/BUILD.bazel:137:1: Target '//internal:common/json_marshal.bzl' contains an error and its package is in error and referenced by '//internal:npm_package_assets'
  | ERROR: /workdir/internal/BUILD.bazel:137:1: Target '//internal:common/module_mappings.bzl' contains an error and its package is in error and referenced by '//internal:npm_package_assets'
  | ERROR: /workdir/internal/BUILD.bazel:137:1: Target '//internal:common/tsconfig.bzl' contains an error and its package is in error and referenced by '//internal:npm_package_assets'
  | ERROR: /workdir/internal/BUILD.bazel:26:1: Target '//internal:common/compilation.bzl' contains an error and its package is in error and referenced by '//internal:bzl'
  | ERROR: /workdir/internal/BUILD.bazel:26:1: Target '//internal:common/json_marshal.bzl' contains an error and its package is in error and referenced by '//internal:bzl'
  | ERROR: /workdir/internal/BUILD.bazel:26:1: Target '//internal:common/module_mappings.bzl' contains an error and its package is in error and referenced by '//internal:bzl'
  | ERROR: /workdir/internal/BUILD.bazel:26:1: Target '//internal:common/tsconfig.bzl' contains an error and its package is in error and referenced by '//internal:bzl'

@gregmagolan gregmagolan changed the title WIP: Update nodejs_binary entry points to labels Update to nodejs rules 0.31.0 Jun 6, 2019
@gregmagolan gregmagolan changed the title Update to nodejs rules 0.31.0 WIP: Update to nodejs rules 0.31.0 Jun 6, 2019
@gregmagolan gregmagolan changed the title WIP: Update to nodejs rules 0.31.0 Update to nodejs rules 0.31.1 Jun 7, 2019
nodejs_binary entry_point is now a label
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants