This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Update to nodejs rules 0.31.1#453
Closed
gregmagolan wants to merge 1 commit intobazelbuild:masterfrom
gregmagolan:nodejs-binary-entry-point-labels
Closed
Update to nodejs rules 0.31.1#453gregmagolan wants to merge 1 commit intobazelbuild:masterfrom gregmagolan:nodejs-binary-entry-point-labels
gregmagolan wants to merge 1 commit intobazelbuild:masterfrom
gregmagolan:nodejs-binary-entry-point-labels
Conversation
Contributor
Author
|
Need rules_nodejs snapshot builds of npm packages to fix the error here that target is using |
Merged
12 tasks
nodejs_binary entry_point is now a label
alexeagle
pushed a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Jun 10, 2019
siberex
pushed a commit
to siberex/rules_nodejs
that referenced
this pull request
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodejs_binary entry_point is now a label. See release notes https://github.com/bazelbuild/rules_nodejs/releases/tag/0.31.0 for more info.
#455 should land first.
This commit is a pre-req to bazel-contrib/rules_nodejs#777