Vlans that have a / in the name in vmware, are imported with the encoded %2f in the name insted

[nathan-march]

If you have a vlan in vmware that contains a / in the name, then netbox's imported vlan name on the VM interface will show %2f instead of /

2020-11-18 22:37:23,796 - DEBUG: Ip address '10.32.0.200/24' attribute 'assigned_object_id' changed from 'None' to 'vNIC 1 (2000-management-10.32.0.0%2f24) (sv1-vcenter)'

[bb-Ricardo]

Thank you for the bug report.

At the moment I can't find the issue causing this behavior. I tried it in a "manual" fashion and the interface was renamed properly including the "/" slash.

Only thing I can think of is that VMWare propagates the portgroup name url encoded. Then it will occure right at the beginning before the host parsing starts in the port group parsing. Please have a look.

Otherwise can you change the name of the interface in NetBox and then rerun the program with DEBUG3?

Thank you

[nathan-march]

If I set the vlan name to the proper / in netbox and then re-run sync, it stays as /. If I then delete that vlan and run the sync, it's recreated with %2f. If I do this with the network interface name, it always changes it back to %2f.

Hopefully this is the useful log section, otherwise let me know which request you need to see:

2020-11-20 00:43:49,939 - DEBUG2: Parsing device VirtualE1000e: 00:0C:29:B1:EF:74
2020-11-20 00:43:49,943 - DEBUG: IP address 'fe80::e54b:710d:b97e:860e/64' for vNIC 3 (2000-sav_management-10.32.0.0%2f24) is a link local address. Skipping.
2020-11-20 00:43:49,943 - DEBUG3: function: add_device_vm_to_inventory
2020-11-20 00:43:49,943 - DEBUG3: Object type <class 'module.netbox.object_classes.NBVM'>
2020-11-20 00:43:49,943 - DEBUG2: Trying to find a virtual machine based on the collected name, cluster, IP and MAC addresses
2020-11-20 00:43:49,944 - DEBUG2: Found a exact matching virtual machine object: SAV-V1-BK01 (SAV-V1A)
2020-11-20 00:43:49,944 - DEBUG2: Found a matching virtual machine object: SAV-V1-BK01 (SAV-V1A)
2020-11-20 00:43:49,944 - DEBUG2: Parsing 'virtual machine' data structure: SAV-V1-BK01
2020-11-20 00:43:49,944 - DEBUG2: Parsing 'cluster' data structure: SAV-V1A
2020-11-20 00:43:49,944 - DEBUG: Updated cluster object: SAV-V1A
2020-11-20 00:43:49,944 - DEBUG2: Parsing 'device role' data structure: Server
2020-11-20 00:43:49,944 - DEBUG: Updated device role object: Server
2020-11-20 00:43:49,944 - DEBUG2: Parsing 'platform' data structure: Microsoft Windows Server 2019 (64-bit)
2020-11-20 00:43:49,944 - DEBUG: Updated platform object: Microsoft Windows Server 2019 (64-bit)
2020-11-20 00:43:49,944 - DEBUG2: Trying to match current this_object interfaces in NetBox with discovered interfaces
2020-11-20 00:43:49,945 - DEBUG2: Found '3' NICs in Netbox for 'SAV-V1-BK01'
2020-11-20 00:43:49,945 - DEBUG2: Found 1:1 name match for NIC 'vNIC 1 (2010-sav-10.32.10.0%2f24)'
2020-11-20 00:43:49,945 - DEBUG2: Found 1:1 name match for NIC 'vNIC 2 (2001-sav_storage-10.32.1.0%2f24)'
2020-11-20 00:43:49,945 - DEBUG2: Found 1:1 MAC address match for virtual NIC 'vNIC 3 (2000-sav_management-10.32.0.0%2f24)'
2020-11-20 00:43:49,945 - DEBUG2: Parsing 'virtual machine interface' data structure: vNIC 1 (2010-sav-10.32.10.0%2f24) (SAV-V1-BK01)
2020-11-20 00:43:49,946 - DEBUG2: Parsing 'VLAN' data structure: 2010 (vCenter: sav)
2020-11-20 00:43:49,946 - DEBUG2: Parsing 'site' data structure: vCenter: sav
2020-11-20 00:43:49,946 - DEBUG: Updated site object: vCenter: sav
2020-11-20 00:43:49,946 - DEBUG: Updated VLAN object: 2010 (vCenter: sav)
2020-11-20 00:43:49,946 - DEBUG2: Parsing 'IP address' data structure: 10.32.10.210/24
2020-11-20 00:43:49,946 - DEBUG: Updated IP address object: 10.32.10.210/24
2020-11-20 00:43:49,946 - DEBUG2: Trying to find prefix for IP: 10.32.10.210/24
2020-11-20 00:43:49,947 - DEBUG2: Parsing 'virtual machine interface' data structure: vNIC 2 (2001-sav_storage-10.32.1.0%2f24) (SAV-V1-BK01)
2020-11-20 00:43:49,947 - DEBUG2: Parsing 'VLAN' data structure: 2001 (vCenter: sav)
2020-11-20 00:43:49,947 - DEBUG2: Parsing 'site' data structure: vCenter: sav
2020-11-20 00:43:49,947 - DEBUG: Updated site object: vCenter: sav
2020-11-20 00:43:49,947 - DEBUG: Updated VLAN object: 2001 (vCenter: sav)
2020-11-20 00:43:49,947 - DEBUG2: Parsing 'IP address' data structure: 10.32.1.210/24
2020-11-20 00:43:49,947 - DEBUG: Updated IP address object: 10.32.1.210/24
2020-11-20 00:43:49,947 - DEBUG2: Trying to find prefix for IP: 10.32.1.210/24
2020-11-20 00:43:49,948 - DEBUG2: Parsing 'virtual machine interface' data structure: vNIC 3 (2000-sav_management-10.32.0.0%2f24) (SAV-V1-BK01)
2020-11-20 00:43:49,948 - DEBUG2: Parsing 'VLAN' data structure: 2000 (vCenter: sav)
2020-11-20 00:43:49,948 - DEBUG2: Parsing 'site' data structure: vCenter: sav
2020-11-20 00:43:49,948 - DEBUG: Updated site object: vCenter: sav
2020-11-20 00:43:49,948 - DEBUG: Updated VLAN object: 2000 (vCenter: sav)
2020-11-20 00:43:49,948 - INFO: Virtual machine interface 'vNIC 3 (2000-sav_management-10.32.0.0%2f24) (SAV-V1-BK01)' attribute 'name' changed from 'vNIC 3 (2000-sav_management-10.32.0.0/24)' to 'vNIC 3 (2000-sav_management-10.32.0.0%2f24)'

[bb-Ricardo]

this definitly comes directly from the pyvmomi IP out of the vCenter.

looking for the part where the progrma retrieves the protgroups: starts with this string: Parsing vCenter port group:

maybe here also uügrading the pyvmomi dependency to a current version migth help the issue

[nathan-march]

Confirmed still happens with latest pyvmomi (7.0.1).

I think this is a vmware bug, since I just noticed that looking at a VM in vsphere it shows the %2f in the vm hardware summary as well as the dropdowns to select the dvportgroup. If you agree, makes sense to close this I think.

[bb-Ricardo]

I would assume vMWare needs to fix a few things first.

I guess we can close this for now.

[bb-Ricardo]

add to branch "development"