Skip to content

develop#184

Merged
Fesenko-A merged 2 commits into
mainfrom
develop
May 15, 2026
Merged

develop#184
Fesenko-A merged 2 commits into
mainfrom
develop

Conversation

@Fesenko-A
Copy link
Copy Markdown
Contributor

@Fesenko-A Fesenko-A commented May 15, 2026

Improved the output of the 'Create transcription' action for Azure OpenAI connection type

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4dcf3da9-2110-4fbb-bbb3-1bb5dc218f0f

📥 Commits

Reviewing files that changed from the base of the PR and between 5f95929 and 2324189.

📒 Files selected for processing (1)
  • Apps.OpenAI/Actions/AudioActions.cs
🚧 Files skipped from review as they are similar to previous changes (1)
  • Apps.OpenAI/Actions/AudioActions.cs

📝 Walkthrough

Walkthrough

BuildTranscription now builds output from response.Segments when present: diarization models group and join consecutive speaker segments into speaker turns; non-diarization models join trimmed non-empty segments with newlines. Also bumps project version to 2.8.46.

Changes

Audio Transcription Segment Formatting

Layer / File(s) Summary
Segment-based transcription output
Apps.OpenAI/Actions/AudioActions.cs
Early guard returns raw response.Text when response.Segments is absent. For diarization models, segments are grouped by speaker, speaker names trimmed, and consecutive segments per speaker batched into speaker turns joined by newlines (or response.Text fallback). For non-diarization models, all non-empty trimmed segment texts are concatenated with newlines (or response.Text if result is blank).
Version update
Apps.OpenAI/Apps.OpenAI.csproj
Project Version bumped from 2.8.45 to 2.8.46.

Possibly Related PRs

  • bb-io/OpenAI#182: Modifies BuildTranscription diarization text formatting with speaker-segment newline separation.
  • bb-io/OpenAI#181: Updates TranscriptionResponse and CreateTranscription to return Words and Segments as structured lists rather than serialized strings.
  • bb-io/OpenAI#183: Adjusts transcription output construction in Apps.OpenAI with newline-separated formatting.

Estimated Code Review Effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Segments whisper, speakers find their line,
Trimmed and joined, the transcript looks fine.
Turns in order, newline-bright,
Diarized voices come to light.
Bumped the version — two eight four six!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The pull request title 'develop' is extremely vague and does not convey any meaningful information about the actual changes made to the codebase. Revise the title to clearly describe the main change, such as 'Improve transcription output handling for diarization and non-diarization models' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Apps.OpenAI/Actions/AudioActions.cs`:
- Around line 127-130: The loop dereferences response.Segments items without
guarding against nulls, which can throw if the API returns a null segment;
update the filtering and/or loop to skip null entries (e.g., change the LINQ
predicate on response.Segments to check x != null &&
!string.IsNullOrWhiteSpace(x.Text) and/or add a guard like if (segment == null)
continue) and also null-check segment.Speaker and segment.Text before Trim() in
the same method so both occurrences (the foreach using response.Segments and the
later loop around lines 147-149) safely handle null segment entries.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e125bbe6-fd3b-43f4-bcb2-e69378d63229

📥 Commits

Reviewing files that changed from the base of the PR and between cd0b85b and 5f95929.

📒 Files selected for processing (2)
  • Apps.OpenAI/Actions/AudioActions.cs
  • Apps.OpenAI/Apps.OpenAI.csproj

Comment thread Apps.OpenAI/Actions/AudioActions.cs Outdated
@Fesenko-A Fesenko-A merged commit c688511 into main May 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant