Update VS 2019 solution to match Makefile and bump version#20
Open
kylekeppler wants to merge 7 commits intobbaggerman:masterfrom
Open
Update VS 2019 solution to match Makefile and bump version#20kylekeppler wants to merge 7 commits intobbaggerman:masterfrom
kylekeppler wants to merge 7 commits intobbaggerman:masterfrom
Conversation
added 6 commits
March 10, 2021 10:30
bbaggerman
requested changes
Jun 7, 2022
Owner
bbaggerman
left a comment
bbaggerman
left a comment
There was a problem hiding this comment.
I think you found a minor bug but got the wrong fix. Rather than wrapping the "break;" in "else" braces I believe it should be un-indented one level and moved outside the "#if". Buy this?
#if defined(IRIG_NETWORKING)
else
enI106_MoveReadPointer(iHandle, (long)llSkipSize);
#endif
break;
bbaggerman
approved these changes
Jun 7, 2022
bbaggerman
approved these changes
Jun 7, 2022
Contributor
Author
|
Think you are right on the break statement. Fix pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated VS 2019 solution to export same functions as gcc Makefile.
Bump version to 1.3.0.
The older VS solutions still need to be updated but I don't have access to older VS versions anymore.