Skip to content

Fix include to make it work with FetchContent_Declare#19

Merged
bbalouki merged 1 commit intobbalouki:mainfrom
kurbakov:main
Dec 17, 2025
Merged

Fix include to make it work with FetchContent_Declare#19
bbalouki merged 1 commit intobbalouki:mainfrom
kurbakov:main

Conversation

@kurbakov
Copy link
Copy Markdown
Contributor

@kurbakov kurbakov commented Dec 17, 2025

Currently the library build will fail if you try to use FetchContent:

include(FetchContent)

FetchContent_Declare(
  itchcpp
  GIT_REPOSITORY https://github.com/bbalouki/itchcpp.git
  GIT_TAG        main
  OVERRIDE_FIND_PACKAGE
)

FetchContent_MakeAvailable(itchcpp)

Due to the usage of the hard-coded path of the include cmake.

Current fix will allow other devs to integrate the library easily.

@bbalouki bbalouki self-requested a review December 17, 2025 20:02
bbalouki
bbalouki approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@bbalouki bbalouki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@bbalouki bbalouki merged commit fda4682 into bbalouki:main Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbalouki bbalouki bbalouki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kurbakov @bbalouki