Bump minor feature versions for mirror/keyserver-updated manifests#3
Merged
Bump minor feature versions for mirror/keyserver-updated manifests#3
Conversation
Agent-Logs-Url: https://github.com/bbartels/features/sessions/f4770407-c8bf-457f-91d4-9ed1af88d766 Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Bump feature versions for modified mirror/keyserver support
Bump minor feature versions for mirror/keyserver-updated manifests
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the semver minor version bumps for all features modified by the mirror/keyserver support work from devcontainers#1620. It updates only the
versionfield in each affectedsrc/*/devcontainer-feature.jsonmanifest.Manifest version bumps (minor)
src/docker-in-docker/devcontainer-feature.json:2.16.1→2.17.0src/dotnet/devcontainer-feature.json:2.5.0→2.6.0src/github-cli/devcontainer-feature.json:1.1.0→1.2.0src/go/devcontainer-feature.json:1.3.3→1.4.0src/java/devcontainer-feature.json:1.8.0→1.9.0src/kubectl-helm-minikube/devcontainer-feature.json:1.3.1→1.4.0src/node/devcontainer-feature.json:1.7.1→1.8.0src/nvidia-cuda/devcontainer-feature.json:3.0.0→3.1.0src/php/devcontainer-feature.json:1.1.4→1.2.0src/powershell/devcontainer-feature.json:2.0.2→2.1.0src/python/devcontainer-feature.json:1.8.0→1.9.0src/ruby/devcontainer-feature.json:1.3.2→1.4.0src/rust/devcontainer-feature.json:1.5.0→1.6.0src/terraform/devcontainer-feature.json:1.4.2→1.5.0Scope
versionline.{ "id": "go", "version": "1.4.0" }Original prompt
Create a pull request in repository
bbartels/featuresagainst branchmainthat bumps the feature versions for all features modified by the existing mirror/keyserver support work reflected in PR devcontainers#1620.Update the
versionfield in each affectedsrc/*/devcontainer-feature.jsonfile using a semver minor bump (x.y.z->x.(y+1).0).Affected features and required target versions:
src/docker-in-docker/devcontainer-feature.json:2.16.1->2.17.0src/dotnet/devcontainer-feature.json:2.5.0->2.6.0src/github-cli/devcontainer-feature.json:1.1.0->1.2.0src/go/devcontainer-feature.json:1.3.3->1.4.0src/java/devcontainer-feature.json:1.8.0->1.9.0src/kubectl-helm-minikube/devcontainer-feature.json:1.3.1->1.4.0src/node/devcontainer-feature.json:1.7.1->1.8.0src/nvidia-cuda/devcontainer-feature.json:3.0.0->3.1.0src/php/devcontainer-feature.json:1.1.4->1.2.0src/powershell/devcontainer-feature.json:2.0.2->2.1.0src/python/devcontainer-feature.json:1.8.0->1.9.0src/ruby/devcontainer-feature.json:1.3.2->1.4.0src/rust/devcontainer-feature.json:1.5.0->1.6.0src/terraform/devcontainer-feature.json:1.4.2->1.5.0Requirements:
bbartels/features:mainwith a concise title describing the minor version bumps for the changed features.The following is the prior conversation context from the user's chat exploration (may be truncated):
User: Bump the version of the feature you changed according to semver. i presumably need to do this for all the features i have changed for my pr in @devcontainers/featuresdevcontainers/pull/1620
Assistant: Yes — for this PR, you should bump the version for each feature whose shipped behavior changed, which in your case looks like all 14 touched features.
Since these changes add new mirror/keyserver override capabilities without obviously removing existing options, the safe/default semver interpretation is minor bumps (
x.Y.z -> x.(Y+1).0) for each affected feature.That gives you:
docker-in-docker:2.16.1→2.17.0dotnet:2.5.0→2.6.0github-cli:1.1.0→1.2.0go:1.3.3→1.4.0java:1.8.0→1.9.0kubectl-helm-minikube:1.3.1→1.4.0node:1.7.1→1.8.0nvidia-cuda:3.0.0→3.1.0php:1.1.4→1.2.0powershell:2.0.2→2.1.0python:1.8.0→1.9.0ruby:1.3.2→1.4.0rust:1.5.0→1.6.0terraform:1.4.2→1.5.0Why minor, not patch:
One caveat: PowerShell is the only one that might deserve extra scrutiny, because you changed version resolution behavior by removing the
aka.ms/powershell-releaseredirect path and falling back to different metadata resolution. If maintainers view that as a breaking behavior change, they could ask for a major bump — but from what I can see, minor still seems reasonable.If you want, I can next generate the exact edits you need for all 14
devcontainer-feature.jsonfiles.User: for the powershell one, isn't it just a fallback? if aka.ms fails?
Assistant: Not as written — it’s not only a fallback if
aka.msfails.From your diff,
resolve_powershell_version()still starts by resolving a URL and extracting a version, but the PR description says you removed theaka.ms/powershell-releaseredirect-based version resolution path and now rely on the existing git-tag helpers / metadata path instead. So the important semver question is:latest/lts/previewchanged for all users, that’s a behavior changemetadata.jsonas a backup when the first lookup returns nothing, that’s more like a patch-level resilience improvementBased on the code shown, this specific block is definitely only a fallback:
So that block alone is patch-like.
But your PR description suggests there may also be a broader change in how the initial resolution works. If your final code path is still:
then yes — I’d treat PowerShell as patch or at least argue patch is defensible.
If instead you replaced the old primary
aka.msmechanism entirely, then minor is still safer.S...
This pull request was created from Copilot chat.