Switch to use built-in helm-grep-ag
#195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `helm-ag` has been removed from MELPA melpa/melpa#9520, with a recommendation to use a Helm built-in `helm-grep-ag`. This commit updates implementation of command `helm-projectile-ag` to use the `helm-grep-ag`. fixes: bbatsov#193 BREAKING CHANGE: Default input is not populated (to be fixed in a following commit). BREAKING CHANGE: Directories to keep (see `projectile-parse-dirconfig-file`) are no longer passed to searcher invocation. BREAKING CHANGE: The Helm source that present search results is now `helm-grep-ag-class`, which results in how results are presented and interacted with. For example actions are now different, and "Edit search results" is no longer available. Type TAB (or C-i) in search results to see available actions.
This commit brings the functionality of a new implementation of `helm-projectile-ag` that uses `helm-grep-ag` to the similar level as the implementation of that has been using `helm-ag`.
Owner
|
Thanks! |
4 tasks
pkryger
added a commit
to pkryger/helm-projectile
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
helm-aghas been removed from MELPAmelpa/melpa#9520, with a recommendation to use a Helm
built-in
helm-grep-ag.Please see individual commits for detailed explanation, including list of
things that has changed due to different implementations.
I decided to split this into two commits, as the population of input may be
changed in a future ant this commit may be reverted (or at least serve as a
guideline for the manual reversion).
fixes: #193
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
M-x checkdocwarningsThanks!