Use UnityInput to support both legacy and new input systems #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from BepInEx to keep support for other plugin loaders.
There was a problem hiding this comment.
Pull request overview
This pull request adds support for both Unity's legacy and new input systems by introducing an abstraction layer called UnityInput. The code is copied from BepInEx to maintain compatibility with other plugin loaders.
Changes:
- Added
UnityInputabstraction layer that automatically detects and uses the best available input system (legacy Input or new InputSystem) - Migrated all direct
Inputclass usage toUnityInput.Currentthroughout the UI and plugin code - Added Unity.InputSystem.dll references to the project file for both net35 and net6.0 target frameworks
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/XUnity.Common/XUnity.Common.csproj | Added Unity.InputSystem.dll references for both target frameworks |
| src/XUnity.Common/Utilities/UnityInput.cs | New file containing abstraction layer with automatic input system detection and support for both legacy and new input systems |
| src/XUnity.AutoTranslator.Plugin.Core/UI/XuaWindow.cs | Migrated from direct Input usage to UnityInput.Current |
| src/XUnity.AutoTranslator.Plugin.Core/UI/TranslationAggregatorWindow.cs | Migrated from direct Input usage to UnityInput.Current |
| src/XUnity.AutoTranslator.Plugin.Core/UI/TranslationAggregatorOptionsWindow.cs | Migrated from direct Input usage to UnityInput.Current |
| src/XUnity.AutoTranslator.Plugin.Core/UI/GUIUtil.cs | Migrated from direct Input usage to UnityInput.Current |
| src/XUnity.AutoTranslator.Plugin.Core/AutoTranslationPlugin.cs | Migrated from direct Input usage to UnityInput.Current for keyboard input handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from BepInEx to keep support for other plugin loaders.
Fixes #329
Fixes #443
Fixes #615
Fixes #728
Fixes #797
Partial #653