JRE Dependency Fix + Port Configuration #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
very nice, many thanks for the contribution! |
nomer
pushed a commit
to nomer/signal-cli-rest-api
that referenced
this pull request
Mar 14, 2023
JRE Dependency Fix + Port Configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not seeing a
CONTRIBUTING.mdfile so I'll do my best to be specific.Main change: Changes the JRE image to a
Bionic-specific image. This change is inDockerfileline 42.This PR also allows the port to be configured through
docker-compose.yml. This means images built usingdocker-composewill use the configured port, but images built usingdocker buildwill still default to port 8080. The environment variable definitions required to do this were added todocker-compose.yml. Nothing breaks if the environment variables are omitted - the API just runs on port 8080 like it does currently.A small change is made to
main.goto detect thePORTenvironment variable and use it to configure Swagger if it exists, but fallback to8080if it does not (like if it is built with the Dockerfile).This PR will resolve #39 and also resolve #42