Merged
Conversation
- not tested
- add more plots
proper plotting generation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to annotate omega values with QC flagging information from mutation density analysis. The changes enable the pipeline to flag gene/sample pairs that fail quality control metrics (based on z-scores) and annotate omega results accordingly.
- Adds conditional execution of PLOTTINGQC workflow based on both
run_mutdensityandparams.omegaflags - Introduces a new ANNOTATE_OMEGA_QC process to merge QC flagging data with omega results
- Simplifies z-score filtering logic in mutation_densities_qc.py to use absolute value comparison
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workflows/deepcsa.nf | Added params.omega condition check and passed OMEGA.out.all_compiled to PLOTTINGQC workflow |
| subworkflows/local/plotting_qc/main.nf | Added ANNOTATE_OMEGA_QC process integration and new input parameter for omega data |
| modules/local/plot/qc/mutation_densities/main.nf | Added compiled_flagged output emission for downstream QC annotation |
| modules/local/plot/qc/annotate_omega/main.nf | New process to annotate omega results with QC flagging data |
| bin/mutation_densities_qc.py | Simplified z-score filtering logic and added compilation of all flagged cases into a single output file |
| bin/annotate_omega_failing.py | New script to merge QC flagging data with omega results and generate summary visualizations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-huertasp
reviewed
Oct 30, 2025
Collaborator
m-huertasp
left a comment
There was a problem hiding this comment.
A lot of work and things here!
I have some questions (below) on how this should work. You'll see it in the comments.
I am not sure if I am missing something but is this working as you expect?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing:
Annotate the QCs for all omega typesI ignore this because the QCs are only relevant for omega, not for omegagloballoc