9 migrate wasm code from golang to rust#10
Conversation
…I8080 and Z80 emulators
- Updated devcontainer configuration to install wasm-pack. - Modified .gitignore to exclude Rust target directory. - Removed Makefile and Go module files as they are no longer needed. - Updated index.html to remove reference to wasm_exec.js. - Added vite-plugin-wasm-pack to package.json and package-lock.json. - Created new Rust project structure with Cargo.toml and Cargo.lock files. - Implemented Rust CPU emulators (i8080 and z80) and their respective logic. - Updated WASM export functions to communicate with JavaScript. - Refactored App.jsx to integrate Rust WASM and handle message passing. - Cleaned up Terminal component to improve logging and message handling. - Removed obsolete Go files related to CPU emulation and main logic.
There was a problem hiding this comment.
Pull request overview
This PR migrates the emulator core from Go to Rust, establishing a modular Rust workspace architecture for CPU emulation and integrating it with the React frontend via WASM. The Go WASM implementation is completely removed, and the build system is updated to use wasm-pack for Rust/WASM compilation.
Key changes:
- Introduced a Rust workspace with modular crates for emulator core, i8080/z80 CPU implementations, and WASM exports
- Replaced Go WASM with Rust WASM bindings using
wasm-bindgen - Updated frontend to communicate with Rust emulator instance via new message-passing layer
Reviewed changes
Copilot reviewed 21 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
wasm/main.go |
Removed Go WASM implementation including emulator config, CPU interface, and JS message passing |
wasm/cpu/z80.go |
Removed Go z80 CPU implementation |
wasm/cpu/i8080.go |
Removed Go i8080 CPU implementation |
rustwasm/Cargo.toml |
Added Rust workspace manifest defining modular crate structure |
rustwasm/emucore/ |
Added placeholder emulator core crate |
rustwasm/cpu_i8080/ |
Added Rust i8080 CPU implementation with register/memory handling |
rustwasm/cpu_z80/ |
Added Rust z80 CPU implementation with register/memory handling |
rustwasm/wasm_export/ |
Added WASM bindings crate exposing Emulator API to JavaScript |
src/App.jsx |
Replaced Go WASM integration with Rust WASM, updated message passing to use Emulator instance |
src/components/Terminal.jsx |
Added output buffering to handle writes before terminal initialization |
package.json |
Updated build scripts for Rust/WASM, added wasm-pack dependency |
vite.config.js |
Removed Go WASM static copy plugin configuration |
index.html |
Removed Go WASM runtime script reference |
.devcontainer/devcontainer.json |
Replaced Go with Rust toolchain and added wasm-pack installation |
README.md |
Updated documentation to reflect Rust architecture and new build process |
Makefile |
Removed Go build configuration |
go.mod |
Removed Go module definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,128 @@ | |||
|
|
|||
There was a problem hiding this comment.
Remove the leading blank line at the start of the file for consistency with other Rust files in the project.
| pub struct Emulator { | ||
| config: EmulatorConfig, | ||
| cpu: CpuType, | ||
| debug_enabled: bool, |
There was a problem hiding this comment.
The debug_enabled field is private but accessed in JavaScript code (line 70 of App.jsx checks emulatorInstance.debug_enabled). This field should be made public or a getter method should be provided to avoid potential issues with WASM bindings.
| case 'memoryWrite': { | ||
| const req = JSON.parse(payload); | ||
| emulatorInstance.memory_write(req.addr, req.value); | ||
| if (emulatorInstance.debug_enabled) { |
There was a problem hiding this comment.
Accessing debug_enabled directly on the Rust WASM instance may fail because the field is private in the Rust struct. The Rust implementation should either make this field public with #[wasm_bindgen] annotation or provide a getter method.
| ### 3. Clean the build output (optional) | ||
|
|
||
| ```bash | ||
| npm run clean |
There was a problem hiding this comment.
The 'clean' script is referenced here but was removed from package.json in this PR. Either restore the clean script or remove this section from the documentation.
This pull request is a major refactor that transitions the emulator core from Go to Rust, introduces a modular Rust workspace for CPU emulation, and updates the frontend to interact with the new Rust/WASM backend. The Go WASM code and build system are removed, and a new Rust-based WASM interface is integrated with the React frontend. Documentation and configuration files are updated to reflect these architectural changes.
Core architecture migration to Rust/WASM:
rustwasm/Cargo.toml) with modular crates for the emulator core (emucore), i8080 CPU (cpu_i8080), z80 CPU (cpu_z80), and WASM export interface (wasm_export). Each crate includes initial structure and basic register/memory handling. [1] [2] [3] [4] [5] [6] [7] [8] [9]Makefile,go.mod, and Go WASM runtime references inindex.html. [1] [2] [3]Frontend integration with Rust/WASM:
src/App.jsx) to load and interact with the Rust WASM module viawasm-pack, replacing the previous Go WASM message-passing logic. Added a new message-passing layer for communication with the RustEmulatorinstance. [1] [2] [3]Build and development environment updates:
.devcontainer/devcontainer.jsonto include Rust and installwasm-packfor WASM builds.package.jsonscripts and dependencies to usewasm-packfor Rust builds, removed Go build steps, and addedvite-plugin-wasm-packfor easier WASM integration. [1] [2]Documentation and project overview:
README.mdto describe the new Rust-based architecture, build steps, and future plans for embedded support. Removed references to Go and updated instructions for building and running the webapp with Rust/WASM.Encoded references:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]