This repository was archived by the owner on Mar 8, 2020. It is now read-only.
New annotations#15
Merged
Merged
Conversation
smola
approved these changes
May 25, 2017
Member
|
This SDK API update needs to be merged first: #16 |
Contributor
Author
|
Rebased |
alcortesm
approved these changes
May 25, 2017
Member
|
@abeaumont rebase again? |
Contributor
Author
|
rebased again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete annotations for tokens somehow related with cyclomatic complexity (with whatever definition we end up choosing at the end), except for the Assert one, since it seems to be showing a rather weird behaviour (appearing as an identifier in the native ast, or not appearing at all) and some complex cases that are marked as such in the code.